Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more configurable datastore configs #3575

Merged
merged 18 commits into from
Sep 4, 2017
+744 −124
Merged

more configurable datastore configs #3575

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
7875674
make datastore configuration nicely customizable
whyrusleeping Mar 15, 2016
0f8b603
cleanup and bug fixes
kevina May 10, 2017
2df7727
bump repo version, remove support for old config
kevina May 20, 2017
ee935ab
address p.r. comments
kevina Jun 13, 2017
5a8c171
add tests for new datastore configuration
kevina Jun 17, 2017
1f97170
Use DatastoreConfig abstraction to create datastores.
kevina Jul 5, 2017
5027b4b
Implement DiskId()
kevina Jul 5, 2017
7b5027f
add basic tests for Spec config change
kevina Jul 6, 2017
3bbe065
write out full spec instead of just the disk id
kevina Jul 7, 2017
d64ab3c
Use the json repr. of the minimal config as the DiskId.
kevina Jul 14, 2017
ce62bed
Write the spec file during initialization only.
kevina Jul 14, 2017
a99448f
Error out on unknown levelds compression rather than assuming the def…
kevina Jul 14, 2017
6438fc7
Add documentation.
kevina Jul 14, 2017
1f8723d
Address p.r. feedback
kevina Jul 14, 2017
19730d4
Sort mountpoints.
kevina Jul 16, 2017
ef5e94a
use dists with new migrations
whyrusleeping Sep 3, 2017
0b0ddef
fix EOF quoting
whyrusleeping Sep 4, 2017
2c30002
fix t0024 on osx
Sep 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Error out on unknown levelds compression rather than assuming the def… 
…ault

License: MIT
Signed-off-by: Kevin Atkinson <[email protected]>
@kevina @whyrusleeping
kevina authored and whyrusleeping committed Sep 3, 2017

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit a99448f0de958e73e11b26f33400d69cea618391
6 changes: 3 additions & 3 deletions repo/fsrepo/datastores.go
View file
Original file line number Diff line number Diff line change
@@ -200,15 +200,15 @@ func LeveldsDatastoreConfig(params map[string]interface{}) (DatastoreConfig, err
return nil, fmt.Errorf("'path' field is missing or not string")
}

switch params["compression"].(string) {
switch cm := params["compression"].(string); cm {
case "none":
c.compression = ldbopts.NoCompression
case "snappy":
c.compression = ldbopts.SnappyCompression
case "":
fallthrough
default:
c.compression = ldbopts.DefaultCompression
Copy link
Member

@Stebalien Stebalien Jul 12, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it ignores garbage values (e.g., "snapy" will silently ignored). If so, this should probably return an error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but didn't write that bit of code so I left it as is. @whyrusleeping agree with @Stebalien?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, agreed. That makes sense

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevina, while we're at it, it would be nice to fix this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oversight, fixed now.

default:
return nil, fmt.Errorf("unrecognized value for compression: %s", cm)
}

return &c, nil