Gxify fuse lib, update it, might fix OSX with new fuzz and move lots of stuff to gx #3414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubuxu
force-pushed
the
feat/gx-fuzz
branch
5 times, most recently
from
7150bfd to
1f0d74b
Compare
Kubuxu
changed the title
|
i wonder why the js-ipfs-api tests are still failing... |
|
This resolves #3410 right? |
|
Ok, I've tested this as well, on OSX 10.11.4 and osx-fuse 3.5.3 and it's working fine now! |
|
@Kubuxu can you rebase this one? |
|
Rebased |
whyrusleeping
force-pushed
the
feat/gx-fuzz
branch
from
d7fd989 to
510ff92
Compare
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
|
@Kubuxu This is such a large diff that it makes me nervous to put it in 0.4.5. Thoughts? |
|
I think I will fixup the messages with FUSE on OSX and let's leave it for next release. I feel like it could delay this one too much. |
Kubuxu
added
status/ready
Closed
|
@Kubuxu update here? Since we want to release 0.4.6 very soon, how about we get this in 0.4.7 in the next week or so? |
|
I think right now it might be easier to do it from grounds up... Rebasing is hell |
|
Closing this, I'll do it part by part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested it on my Arch Linux 4.7.6 machine.
It might solve more issues we are seeing with FUSE.
Resolves #3471
License: MIT
Signed-off-by: Jakub Sztandera [email protected]