fix: on windows, add path use absolute, more add object for father path

[liliuhai]

old code run on winodw,use add -r commands,if use absolute path as param,the result have more added object like father path,but use relativity path,no this problem.

License: MIT
Signed-off-by: liliuhai [email protected]

[djdv]

I believe it would be more appropriate to change line 401 fpath, err := filepath.EvalSymlinks(fpath) to fpath, err := filepath.ToSlash(filepath.EvalSymlinks(fpath)) instead, fpath is supposed to be standardized to forward slashes to prevent this kind of problem, it seems fe7b01f may have re-introduced this problem by reassigning fpath from standard forward slashes into platform specific paths.

For reference on standard slash paths #1933 (comment)

ping @Kubuxu

[liliuhai]

I think filepath.EvalSymlinks function cause problem，in winodws，before call EvalSymlinks，fpath is use “\”，but after called fpath changed for “/"，so re-introduced this problem.

[djdv]

Sorry, I neglected the multiple return values of EvalSymlinks, this is what I should have suggested: djdv@31b4cbb

[liliuhai]

thanks, like this the problem can fixed

[djdv]

Sounds good, we'll have to wait for an IPFS member to make judgment since I don't know which method is preferable or if anything else has to be done. I'm glad this regression was spotted, thank you for finding it!

[whyrusleeping]

@djdv @liliuhai Would this issue have been caught by our existing sharness tests?

[whyrusleeping]

instead of doing this here, we should on line 401 do:

fpath = filepath.Clean(fpath)
fpath, err = filepath.EvalSymlinks(fpath)
...
fpath = filepath.ToSlash(fpath)

[Kubuxu]

I've taken over this PR in #3023. Thanks for bringing it up to us.

We need to work on Windows CI.