In blockstore tests treat Close and Closing the same way #2832
Conversation
|
I'm not sure i follow how this solves the issue, could you elaborate? |
|
If the cancel is run in the same goroutine then it will send signal to the already waiting goroutine which will cause the goprocess to close. By running it in separate goroutine we should give ourselves enough time to reach the |
|
This fix doesn't work as I thought it would. |
As there is no piority system for select and it chooses channel at random if multiple are read and time difference between Close and Closing is very small it is best solution to this problem. License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
Kubuxu
force-pushed
the
feature/test-datastore
branch
from
87cd2ea
to
522c590
Compare
Kubuxu
changed the title
|
I've changed the approach as that one was not working and I was able to replicate the issue by repeatability running tests. |
|
Ok, it looks like it isn't test inconsistency after all. I am getting failures at https://github.com/ipfs/go-ipfs/pull/2832/files#diff-89a41509a8389c8bc3dbf7594aa13416R192 now. |
This should prevent race condition that caused #2762
Resolves #2762
License: MIT
Signed-off-by: Jakub Sztandera [email protected]