Add helptext, default logic to ipfs stats
#2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGMT IIRC Teamcity fail seems to be unrelated. |
RichardLitt
force-pushed
the
feature/spruce-upstat
branch
from
fbba4d6 to
14023a0
Compare
|
Updated synopsis to match Yeah, |
RichardLitt
force-pushed
the
feature/spruce-upstat
branch
from
14023a0 to
6245903
Compare
|
Fixed spacing. |
|
LGTM but you have binary files in your PR. |
RichardLitt
force-pushed
the
feature/spruce-upstat
branch
from
6245903 to
56fcb10
Compare
|
Fixed. |
| Tagline: "Query ipfs statistics.", | ||
| Synopsis: "ipfs stats <command>", | ||
| ShortDescription: `'ipfs stats' is a set of commands to help look at statistics for your ipfs node.`, | ||
| LongDescription: `'ipfs stats' is a set of commands to help look at statistics for your ipfs node.`, |
There was a problem hiding this comment.
I think we can probably add some logic that sets the long description to the short description if unset
There was a problem hiding this comment.
(not that you have to change anything here, just saying that might be a nice feature)
whyrusleeping
added
need/author-input
RichardLitt
force-pushed
the
feature/spruce-upstat
branch
2 times, most recently
from
b920e36 to
1523ae3
Compare
|
LGTM |
| return | ||
| } | ||
| interval = v | ||
| v, err := time.ParseDuration(timeS) |
whyrusleeping
added
need/author-input
I've added: Synopsis, shortDescription, and longDescription for stats and stats bw.
I also added default(false) for poll and default("1s") for interval, and modified the logic to make it fit.
Part of #2484 and #2647.
License: MIT
Signed-off-by: Richard Littauer <[email protected]>
RichardLitt
force-pushed
the
feature/spruce-upstat
branch
from
1523ae3 to
8ee399f
Compare
RichardLitt
added
need/review
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added: Synopsis, shortDescription, and longDescription for stats and stats bw.
I also added default(false) for poll and default("1s") for interval, and modified the logic to make it fit.
Part of #2484 and #2647.
License: MIT
Signed-off-by: Richard Littauer [email protected]