fix panic in cli arg parsing #2354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@noffle could I get you to CR this one? |
License: MIT Signed-off-by: Jeromy <[email protected]>
whyrusleeping
force-pushed
the
fix/stdin-arg-parse
branch
from
10ad07b
to
dbf0185
Compare
| peer "gx/ipfs/QmUBogf4nUefBjmYjn6jfsfPJRkmDGSeMhNj4usRKq69f4/go-libp2p/p2p/peer" | ||
| u "gx/ipfs/QmZNVWh8LLjAavuQ2JXuFmuYH3C11xo988vSgp7UQrTRj1/go-ipfs-util" |
There was a problem hiding this comment.
Nitpick: I know gophers love short var names, but u -> util would be nice.
There was a problem hiding this comment.
yeah, i opted for not making lots of changes to the codebase. we can do a codebase-wide change for that later
|
🐴 LGTM This PR feels like a bandaid on top of some already fairly hard to follow code. It'd be nice if we could simplify the complex |
youre not wrong. |
whyrusleeping
added a commit
that referenced
this pull request
Feb 18, 2016
fix panic in cli arg parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1735
License: MIT
Signed-off-by: Jeromy [email protected]