Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enumerate log level subsystem commands #2306

Closed
wants to merge 1 commit into from

Conversation

RichardLitt
Copy link
Member

See #2305

License: MIT
Signed-off-by: Richard Littauer [email protected]

See #2305

License: MIT
Signed-off-by: Richard Littauer <[email protected]>
@Kubuxu
Copy link
Member

Kubuxu commented Feb 5, 2016

There are more subsystems and even more sub-subsystems.

@RichardLitt
Copy link
Member Author

Cool. What are they? Can you log subsubsystems?

@Kubuxu
Copy link
Member

Kubuxu commented Feb 5, 2016

I always have to search the code when looking for logger that is handling given system. I have no idea if there is some general solution.

Example of subsubsystem logger: https://github.com/ipfs/go-ipfs/blob/master/core/corehttp/corehttp.go#L20

@RichardLitt
Copy link
Member Author

So, that's less than ideal, because someone may not know they can search for them. How do you know if something is a subsystem? How does the system know?

@Kubuxu
Copy link
Member

Kubuxu commented Feb 6, 2016

Here are all logger modules: https://gist.github.com/Kubuxu/ff5c472713a3f058049f

@RichardLitt
Copy link
Member Author

Hmm. That is a lot. Maybe we can mention that in the mans? Not all of them, but a way to find them all? Maybe even just that grep command. cc @whyrusleeping

@whyrusleeping
Copy link
Member

we could have a log subcommand that lists all registered logger subsystems

@RichardLitt
Copy link
Member Author

I would like that.

@dignifiedquire
Copy link
Member

@whyrusleeping I just found this interesting log event: github.com/ipfs/go-libp2p/p2p/net/swarm/addr which is probably not meant like this

@whyrusleeping
Copy link
Member

@RichardLitt what do we want to do here? There are too many subsystems to enumerate in the argument description.

@RichardLitt
Copy link
Member Author

@whyrusleeping: "we could have a log subcommand that lists all registered logger subsystems"

We should do this. It should be called ipfs log ls. Basically, just build a go-process to create the list Kubuxu pasted above.

@whyrusleeping
Copy link
Member

@RichardLitt cool, i'll file an issue describing that command, and then close this PR

@whyrusleeping whyrusleeping deleted the feature/log-level-subsystem-enum branch March 3, 2016 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants