Removed extra space #2282
Merged
Removed extra space #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The space should still be there. The underlying issue is in the err being formatted in https://github.com/ipfs/go-ipfs/blob/585ef2b957beeb40175a18309aaa9e138f5774f2/repo/common/common.go#L24 (it should be e.g. if |
|
agreed with @rht, we could either special case it, or use |
|
I think |
This was coming up as an extra space. For instance: ```curl -i http://localhost:5001/api/v0/config?arg=kitten //"Message": "Failed to get config value: key has no attributes", ``` Removing it here. License: MIT Signed-off-by: Richard Littauer <[email protected]>
RichardLitt
force-pushed
the
docs/remove-extra-space
branch
from
64e5a95
to
dc5b45e
Compare
|
The err message would still be |
|
I tried loading the config file in node, but: $cp config config.json
$node
> var config = require('./config')
> config.kitten
(no err message. though this is also the case with golang's map) |
|
Cool, this works for me for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was coming up as an extra space. For instance:
Removing it here.
License: MIT
Signed-off-by: Richard Littauer [email protected]