Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finally add changelog for v0.3.11 #2248

Merged
merged 3 commits into from
Jan 28, 2016
Merged

Conversation

whyrusleeping
Copy link
Member

License: MIT
Signed-off-by: Jeromy [email protected]

License: MIT
Signed-off-by: Jeromy <[email protected]>
@whyrusleeping
Copy link
Member Author

@RichardLitt wanna help me look this over?


* BugFixes
* Fix path parsing for add command (@djdv)
* namesys: Make paths with multiple segemnts work. Fixes #2059 (@Kubuxu)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/segemnts/segments/

License: MIT
Signed-off-by: Richard Littauer <[email protected]>
@RichardLitt
Copy link
Member

Fixed. LGTM now.

@rht
Copy link
Contributor

rht commented Jan 27, 2016

@RichardLitt if you look at the past commits in CHANGELOG.md, not all of them are capitalized. The option is either to keep it consistent with the commit messages, or fix it once for all.

@dignifiedquire
Copy link
Member

There is no note about the webui update

@RichardLitt
Copy link
Member

@rht I don't think we have to make a hard & fast rule here about that. There was at least a spelling error in one of the commits which needed to be fixed. @whyrusleeping asked me to look over it; this is what I naturally do when I look over things. :)

@RichardLitt
Copy link
Member

@dignifiedquire Should that be in the go-ipfs changelog?

@dignifiedquire
Copy link
Member

@RichardLitt I think so, as it changes the version that is being shipped with the binary (and it was a commit into this repo)

@rht
Copy link
Contributor

rht commented Jan 27, 2016

webui update came after 0.3.11: https://github.com/ipfs/go-ipfs/commits/master?page=6.

@rht
Copy link
Contributor

rht commented Jan 27, 2016

(I wasn't being asked, but just commented of imo on the consistency)

@dignifiedquire
Copy link
Member

webui update came after 0.3.11: https://github.com/ipfs/go-ipfs/commits/master?page=6.

😱

@whyrusleeping
Copy link
Member Author

the webui update is technically part of 0.3.11 (its inside the tagged release)

License: MIT
Signed-off-by: Jeromy <[email protected]>
@rht
Copy link
Contributor

rht commented Jan 27, 2016

Also, there is http://manpages.ubuntu.com/manpages/lucid/man1/git-dch.1.html for auto-generating debian changelog, e.g. http://changelogs.debian.net/coreutils (using this would pick the "no strict capitalizing of the commit message" option).

@whyrusleeping
Copy link
Member Author

git log --oneline v0.3.10..v0.3.11 | grep -v Merge > full list and then i organize, and remove redundant messages

@whyrusleeping
Copy link
Member Author

@RichardLitt @dignifiedquire do i have a LGTM ?

@dignifiedquire
Copy link
Member

LGTM

@rht
Copy link
Contributor

rht commented Jan 28, 2016

(Except for the cap consistency issue I pointed out, LRGTM)

@RichardLitt
Copy link
Member

LGTM

whyrusleeping added a commit that referenced this pull request Jan 28, 2016
finally add changelog for v0.3.11
@whyrusleeping whyrusleeping merged commit f631db7 into master Jan 28, 2016
@whyrusleeping whyrusleeping deleted the fix/0.3.11-changelog branch January 28, 2016 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants