Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace imports with absolute path instead of using symlink #1773

Merged
merged 1 commit into from
Oct 3, 2015

Conversation

whyrusleeping
Copy link
Member

I dont like this. Not one bit. but it should fix windows builds. Im restraining myself from ranting about windows here.

License: MIT
Signed-off-by: Jeromy [email protected]

@jbenet jbenet added the status/in-progress In progress label Oct 1, 2015
@jbenet
Copy link
Member

jbenet commented Oct 1, 2015

could @gatesvp @Mithgol or someone else with windows verify?

@gatesvp
Copy link
Contributor

gatesvp commented Oct 1, 2015

> git checkout master
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
> go build -tags nofuse
c:\go_code\src\github.com\ipfs\go-ipfs\blocks\blockstore\blockstore.go:15:2: cannot find package "github.com/ipfs/go-ipfs/vendor/go-log-v1.0.0" in any of:
        C:\Go\src\github.com\ipfs\go-ipfs\vendor\go-log-v1.0.0 (from $GOROOT)
        c:\go_code\src\github.com\ipfs\go-ipfs\vendor\go-log-v1.0.0 (from $GOPATH)
>  git checkout feat/no-symlink
Branch feat/no-symlink set up to track remote branch feat/no-symlink from origin.
Switched to a new branch 'feat/no-symlink'
>  go build -tags nofuse
> .\ipfs.exe version
ipfs version 0.3.8-dev

That's a success from my end!

@jbenet
Copy link
Member

jbenet commented Oct 2, 2015

thanks @gatesvp !

@whyrusleeping needs rebase i think

@whyrusleeping
Copy link
Member Author

image

@whyrusleeping
Copy link
Member Author

im downloading a windows vm, going to set up a local jenkins thing so i can test on various different systems.

@whyrusleeping
Copy link
Member Author

windows vm installed and setup. This PR lets us build (-tags=nofuse still required).

Once this lands lets see about rebasing #1705 to make things even easier.

jbenet added a commit that referenced this pull request Oct 3, 2015
replace imports with absolute path instead of using symlink
@jbenet jbenet merged commit 1b79501 into master Oct 3, 2015
@jbenet jbenet deleted the feat/no-symlink branch October 3, 2015 21:56
@jbenet jbenet removed the status/in-progress In progress label Oct 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants