S3 0.4.0 #1488
Merged
S3 0.4.0 #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uhh #1261 much? |
|
Oh I see that pull request is against master; it's that old. |
Closed
|
@tv42 yeah, no worries! we've been putting off merging this for way too long. |
whyrusleeping
force-pushed
the
s3-0.4.0
branch
2 times, most recently
from
f06caf3 to
2dc3ab7
Compare
|
@whyrusleeping not sure why the tests failed. also looks like it needs to be rebased? otherwise LGTM |
The generated file went through some changes because of differing go-bindata versions. License: MIT Signed-off-by: Tommi Virtanen <[email protected]>
License: MIT Signed-off-by: Tommi Virtanen <[email protected]>
License: MIT Signed-off-by: Tommi Virtanen <[email protected]>
License: MIT Signed-off-by: Tommi Virtanen <[email protected]>
License: MIT Signed-off-by: Tommi Virtanen <[email protected]>
This gives us a clean slate for the new code, avoiding leftovers. License: MIT Signed-off-by: Tommi Virtanen <[email protected]>
Earlier, it also checked checked the leveldb directory. That part added no crash safety to the application, and just hardcoded assumptions about the datastore. If anything, this should rely on the absolute last item created by fsrepo.Init, and there should be fsync guarantees about ordering. License: MIT Signed-off-by: Tommi Virtanen <[email protected]>
License: MIT Signed-off-by: Tommi Virtanen <[email protected]>
License: MIT Signed-off-by: Tommi Virtanen <[email protected]>
…m for S3 License: MIT Signed-off-by: Tommi Virtanen <[email protected]>
…"private" License: MIT Signed-off-by: Tommi Virtanen <[email protected]>
To test it, set up an S3 bucket (in an AWS region that is not US
Standard, for read-after-write consistency), run `ipfs init`, then
edit `~/.ipfs/config` to say
"Datastore": {
"Type": "s3",
"Region": "us-west-1",
"Bucket": "mahbukkit",
"ACL": "private"
},
with the right values. Set `AWS_ACCESS_KEY_ID` and
`AWS_SECRET_ACCESS_KEY` in the environment and you should be able to
run `ipfs add` and `ipfs cat` and see the bucket be populated.
No automated tests exist, unfortunately. S3 is thorny to simulate.
License: MIT
Signed-off-by: Tommi Virtanen <[email protected]>
License: MIT Signed-off-by: Tommi Virtanen <[email protected]>
License: MIT Signed-off-by: Jeromy <[email protected]>
License: MIT Signed-off-by: Jeromy <[email protected]>
|
@jbenet can we merge this? |
|
this is failing go tests on mac pretty reliably. 0/6 (3x2) successes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR'ing @tv42's s3 branch against dev0.4.0