Migrated Dockerfile to use alpine linux

[Luzifer]

@jbenet PTAL

TODO:

• Check checksum for downloaded asset

[GitCop]

There were the following issues with your Pull Request

• Commit: 6f50c70
  • Invalid signoff. Commit message must end with License: MIT
    Signed-off-by: .* <.*>

Guidelines are available to help. Your feedback on GitCop is welcome on this issue

---

This message was auto-generated by https://gitcop.com

[jbenet]

this LGTM. rerunning tests

[jbenet]

thanks @Luzifer !

[jbenet]

also cc @lgierth for CR

[GitCop]

There were the following issues with your Pull Request

• Commit: 6f50c70
  • Invalid signoff. Commit message must end with License: MIT
    Signed-off-by: .* <.*>
• Commit: 9f34551
  • Invalid signoff. Commit message must end with License: MIT
    Signed-off-by: .* <.*>

Guidelines are available to help. Your feedback on GitCop is welcome on this issue

---

This message was auto-generated by https://gitcop.com

[GitCop]

There were the following issues with your Pull Request

• Commit: 6f50c70
  • Invalid signoff. Commit message must end with License: MIT
    Signed-off-by: .* <.*>
• Commit: 9f34551
  • Invalid signoff. Commit message must end with License: MIT
    Signed-off-by: .* <.*>
• Commit: 6fb9fee
  • Invalid signoff. Commit message must end with License: MIT
    Signed-off-by: .* <.*>

Guidelines are available to help. Your feedback on GitCop is welcome on this issue

---

This message was auto-generated by https://gitcop.com

[GitCop]

There were the following issues with your Pull Request

• Commit: a245a27
  • Invalid signoff. Commit message must end with License: MIT
    Signed-off-by: .* <.*>

Guidelines are available to help. Your feedback on GitCop is welcome on this issue

---

This message was auto-generated by https://gitcop.com

[Luzifer]

@jbenet PTAL again. Now with checksum checking

[ghost]

I'd prefer if we build from source, for a number of reasons:

• we don't need the shacheck script
• we can build images from local changes or feature branches (important, imo)
• we can strip down the size a bit more by using the musl libc

[jbenet]

But then we need the go compiler, which isn't small.

+1 for building from branches.

The hash check should prob still happen (if we can get go to be reproducible).

[ghost]

Anyhow, let's go with this for now 👍

My comments are not a blocker regarding that blog posting.

[jbenet]

@Luzifer gitcop is complaining because you have

License: MIT Signed-off-by: Knut Ahlers <[email protected]>

it expects:

License: MIT
Signed-off-by: Knut Ahlers <[email protected]>

maybe use: https://github.com/ipfs/community/blob/master/dev/tools/hooks/setup_commit_msg_hook.sh

(doesn't matter for this, i'll merge it)

[jbenet]

ideally we should use the multihash tool (it's already in the Godeps), but that can be an improvement later.

[jbenet]

thanks @Luzifer @lgierth

[RX14]

Would it not be better to make the Dockerfile build from current source rather than the latest gobuilder, because then with the docker auto build you get actual latest, and I presume the docker auto builds are faster than the gobuilder builds.

[balupton]

this seems undone by looking at the latest master - any solutions for using go-ipfs on alpine linux docker containers?

[ghost]

@balupton you'll have to build go-ipfs yourself in an Alpine container (or another way that makes sure it's linked against musl libc). We generally don't have containers or prebuilt binaries linked with musl, but we'd like to in the future.