mild refactor of bitswap #1199
Merged
mild refactor of bitswap #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // TODO: consider changing this function to not return anything | ||
| return "", nil | ||
| return bs.cancelBlocks(ctx, keys) |
There was a problem hiding this comment.
this error probably should not be returned by ReceiveMessage, but logged or otherwise handled. AFAIK, if this fails, it does not mean a ReceiveMessage failure.
There was a problem hiding this comment.
(agree with the general sentiment of not hiding errors, but incorrect errors aren't good either)
|
github's complaining. looks like it needs a rebase? |
whyrusleeping
force-pushed
the
feat/bsrefactor
branch
from
7551bd7 to
9049dae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a mild cleanup of bitswap to remove some unused code and return errors from a few more functions because i hate not returning errors when i am able to. Functionally, nothing is changed.
I also removed a test from
exchange/bitswap/testnetthat was testing unused code.