Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test sort cmp #1011

Merged
merged 2 commits into from
Apr 4, 2015
Merged

Test sort cmp #1011

merged 2 commits into from
Apr 4, 2015

Conversation

chriscool
Copy link
Contributor

This implements a test_sort_cmp() shell function that just sorts the files passed as arguments before calling test_cmp() on the sorted files. This simplifies test scripts.

chriscool added 2 commits April 4, 2015 07:37
@chriscool
test: implement test_sort_cmp()
1f15071 
License: MIT
Signed-off-by: Christian Couder <[email protected]>
@chriscool
t0080: use test_sort_cmp()
c2e9a08 
License: MIT
Signed-off-by: Christian Couder <[email protected]>
@jbenet jbenet added the status/in-progress In progress label Apr 4, 2015
@chriscool
Copy link
Contributor Author

One test fails in t0090-get.sh but it is not related.

@whyrusleeping
Copy link
Member

I really dont know why those tarchive tests have been failing recently... its kinda weird

@chriscool
Copy link
Contributor Author

When I build ipfs with -race and try the following (which is part of t0090-get.sh):

echo "Hello Worlds!" >data &&
HASH=`ipfs add -q data` &&
ipfs get "$HASH" >actual

I get a lot of debug output and Found 8 data race(s).

@chriscool
Copy link
Contributor Author

I opened issue #1012 (ipfs get race conditions).

@whyrusleeping whyrusleeping added the kind/test Testing work label Apr 4, 2015
@jbenet
Copy link
Member

jbenet commented Apr 4, 2015

I get a lot of debug output and Found 8 data race(s).

wow. great finds!

this PR LGTM. merging

jbenet added a commit that referenced this pull request Apr 4, 2015
@jbenet
Merge pull request #1011 from ipfs/test_sort_cmp
07d9cdb 
Test sort cmp
@jbenet jbenet merged commit 07d9cdb into master Apr 4, 2015
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Apr 4, 2015
@jbenet jbenet deleted the test_sort_cmp branch April 4, 2015 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chriscool chriscool

Labels
kind/test Testing work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chriscool @whyrusleeping @jbenet