Gateway: add UseInlinedDNSLink flag to config #9243
Assignees
Labels
kind/bug
A bug in existing code (including security flaws)
kind/enhancement
A net-new feature or improvement to an existing feature
P1
High: Likely tackled by core team if no one steps up
topic/gateway
Topic gateway
Comments
lidel
added
kind/enhancement
lidel
added
kind/bug
|
I'm re-classifying this as a bug, because Brave is unable to use inlined names on localhost (without HTTPS), because existing logic is built around around We agreed this will be fixed in Kubo 0.17. |
Closed
|
@hacdias this is small and sweet thing to work on to warm up :) Let's chat about this next week. |
Repository owner
moved this from 🔎 In Review
to 🎉 Done
in IPFS Shipyard Team
Oct 11, 2022
lidel
added a commit
that referenced
this issue
Oct 11, 2022
#9243 Co-authored-by: Marcin Rataj <[email protected]>
hacdias
added a commit
to ipfs/boxo
that referenced
this issue
Jan 27, 2023
ipfs/kubo#9243 Co-authored-by: Marcin Rataj <[email protected]> This commit was moved from ipfs/kubo@4291d6b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current state
Public gateways inline DNSLink names into a single label if
X-Forwarded-Proto: httpsis present (see docs)https://dweb.link/ipns/en.wikipedia-on-ipfs.org→ redirect →https://en-wikipedia--on--ipfs-org.ipns.dweb.link/wiki/Localhost gateway does not do that, it keeps the subdomains as they are:
http://localhost:48080/ipns/en.wikipedia-on-ipfs.org→ redirect →http://en.wikipedia-on-ipfs.org.ipns.localhost:48080/wiki/Requested enhancement
Brave team asked for a configuration flag that enables DNSLink name inlining into a single DNS label without switching protocol to https (brave/brave-browser#22927).
Proposed design
Add new optional
FlagtoGateway.PublicGatewaysnamedUseInlinedDNSLink(disabled by default).The text was updated successfully, but these errors were encountered: