Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix log filename unhelpful #592

Closed
whyrusleeping opened this issue Jan 17, 2015 · 3 comments
Closed

Prefix log filename unhelpful #592

whyrusleeping opened this issue Jan 17, 2015 · 3 comments
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) topic/cleanup Topic cleanup

Comments

@whyrusleeping
Copy link
Member

There are lots of logs using prefixlog that print out a message, but give no indication of where that message originated from, since the log function is being called from inside prefixlog. This can be solved by increasing the value of ExtraCallDepth on the logger object itself: https://github.com/op/go-logging/blob/4d186fb040e7e748df3736262acc9816156cc194/logger.go#L88

@whyrusleeping whyrusleeping added the kind/bug A bug in existing code (including security flaws) label Jan 17, 2015
@jbenet
Copy link
Member

jbenet commented Jan 17, 2015

@whyrusleeping yeah I opened op/go-logging#44 before the ExtraCallDepth merged to master. We just haven't updated to the new version and changed logger to deal with this.

@jbenet
Copy link
Member

jbenet commented Jan 17, 2015

This requires:

  • vendoring op/go-logging again instead of my fork
  • wrapping go-logging to fit our StandardLogger interface (i.e. what my fork did)
  • setting the ExtraCallDepth in the prefix logger.
  • moving everything to use one logger (i think we want eventlog)

Nice:

  • moving the logging stuff out of util and into its own package (util/logging ?)

Long term good idea (though this still needs work):

I started on this here: https://github.com/jbenet/go-ipfs/tree/fix/logging/stash -- but i'm shifting to do something else, sorry. that branch is basically a stash.

@jbenet
Copy link
Member

jbenet commented Jun 18, 2015

Closed in #1359

@jbenet jbenet closed this as completed Jun 18, 2015
@RichardLitt RichardLitt added the exp/novice Someone with a little familiarity can pick up label Feb 2, 2016
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
…com/libp2p/go-libp2p-0.8.1

build(deps): bump github.com/libp2p/go-libp2p from 0.8.0 to 0.8.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) topic/cleanup Topic cleanup
Projects
None yet
Development

No branches or pull requests

3 participants