-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Required String arugments with stdin handling enabled block --help #2868
Comments
@Kubuxu which commands does this affect? |
Many of them, there are about 30 StringArgs with Stdin handling enabled. |
hrm... I like being able to pipe arguments directly to the commands. Maybe theres a way to defer the processing of the arguments until later? |
Not without introducing terminal vs pipe inconsistency again: #2877 I didn't know that you could directly pipe into commands for quite some time. |
@Kubuxu is this resolved? If so, can you PR in a test that just runs |
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
sharness: Tests for #2868 - --help hanging on stdin
Introduced in: #2822
As the string arguments from stdin are resolved before the command is run it halts execution of the command and waits for the input.
The simplest and the most sane solution would be to remove stdin from String arguments.
All Unix based system all include
xargs
command that does exactly that and current behaviour ofipfs
command rises more confusion than it is useful.My proposition would be to remove
EnableStdin
from non file type arguments and also log it/crash as an error in command creation routines.The text was updated successfully, but these errors were encountered: