Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipfs add -r directory on Windows uses backslash #1676

Closed
Quiark opened this issue Sep 10, 2015 · 6 comments
Closed

ipfs add -r directory on Windows uses backslash #1676

Quiark opened this issue Sep 10, 2015 · 6 comments

Comments

@Quiark
Copy link

Quiark commented Sep 10, 2015

> ipfs add -r overlog.git
QmVUbPiL92L6tp4vVcYQfkB9kmUm2a5QmWKsBWHkzB3NFo 456    overlog.git\COMMIT_EDITMSG
QmVn8wX5YruwN8kd82Qk7eea5b7vw8VLvu2mJc7PCqyyiT 103    overlog.git\FETCH_HEAD
QmWeKwYTKwBwVd7AKioXTmtpLFxTk3MBBk2ef2JtwCccAi 31     overlog.git\HEAD
QmcbSU3g2N5m6uFk8NpXL86BpJo5rmnxirU3ftaSFsadqq 49     overlog.git\ORIG_HEAD
QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn 4      overlog.git\branches/

I suppose all folders in ipfs should be named using /

This behaviour is a problem because for example git-remote-ipfs cannot find overlog.git/refs but overlog.git\refs exists.

@Quiark
Copy link
Author

Quiark commented Sep 10, 2015

digging into the code now..., not sure if the problem is actually in remote-helper-ipfs

Quiark added a commit to Quiark/go-ipfs that referenced this issue Sep 12, 2015
@Quiark
Copy link
Author

Quiark commented Sep 12, 2015

Oh neat, it includes my commit. It doesn't work though. ipfs ls $HASH does list files with normal slash but they aren't actually accessible.

@whyrusleeping
Copy link
Member

Where do the backslashes come from? are you on windows?

@Quiark
Copy link
Author

Quiark commented Sep 12, 2015

Yes, Windows, that's the point :)

On Sun, 13 Sep 2015 02:42 Jeromy Johnson [email protected] wrote:

Where do the backslashes come from? are you on windows?


Reply to this email directly or view it on GitHub
#1676 (comment).

@jbenet
Copy link
Member

jbenet commented Sep 13, 2015

things need to be using filepath, not path when touching the OS i think?

@whyrusleeping
Copy link
Member

can be closed now that #1933 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants