Skip to content

Commit

Permalink
Requested changes
Browse files Browse the repository at this point in the history
  • Loading branch information
ajnavarro committed Oct 19, 2022
1 parent 1482f82 commit ad81a06
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions core/node/libp2p/rcmgr_logging.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,12 @@ func (n *loggingResourceManager) start(ctx context.Context) {

for e, count := range errs {
n.previousErrors = true
n.logger.Errorf("Resource limits were exceeded %d times with error %q. Consider inspecting logs and raising the resource manager limits.", count, e)
n.logger.Errorf("Resource limits were exceeded %d times with error %q. Consider inspecting logs and raising the resource manager limits. Documentation: https://github.com/ipfs/kubo/blob/master/docs/config.md#swarmresourcemgr", count, e)
}

if len(errs) == 0 && n.previousErrors {
n.previousErrors = false
n.logger.Errorf("Resource limits were back to normal.")
n.logger.Errorf("Resrouce limits are no longer being exceeded.")
}

n.mut.Unlock()
Expand Down
2 changes: 1 addition & 1 deletion core/node/libp2p/rcmgr_logging_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func TestLoggingResourceManager(t *testing.T) {
if oLogs.Len() == 0 {
continue
}
require.Equal(t, "Resource limits were exceeded 2 times with error \"system: cannot reserve inbound connection: resource limit exceeded\". Consider inspecting logs and raising the resource manager limits.", oLogs.All()[0].Message)
require.Equal(t, "Resource limits were exceeded 2 times with error \"system: cannot reserve inbound connection: resource limit exceeded\". Consider inspecting logs and raising the resource manager limits. Documentation: https://github.com/ipfs/kubo/blob/master/docs/config.md#swarmresourcemgr", oLogs.All()[0].Message)
return
}
}
Expand Down

0 comments on commit ad81a06

Please sign in to comment.