feat(http): make swarm interface-ipfs-core compliant

[dignifiedquire]

Currently fails on ipfs swarm addrs tests. ipfs-api currently expects to get a map, of addresses indexed by peers. It then flattens it, so that the current results for ipfs swarm peers and ipfs swarm addrs are identical, which makes little sense to me.

I suggest keeping peers as is, but changing ipfs swarm addrs to return a map as go ipfs does:

> ipfs swarm addrs
QmSoLV4Bbm51jM9C4gDYZQ9Cy3U6aXMJDAbzgu2fzaDs64 (5)
    /ip4/104.236.76.40/tcp/4001
    /ip4/127.0.0.1/tcp/4001
    /ip4/172.17.0.1/tcp/4001
    /ip6/::1/tcp/4001
    /ip6/fcd8:a4e5:3af7:557e:72e5:f9d1:a599:e329/tcp/4001
QmSoLju6m7xTh3DuokvT3886QRYqxAzb1kShaanJgW36yx (5)
    /ip4/104.236.151.122/tcp/4001
    /ip4/127.0.0.1/tcp/4001
    /ip4/172.17.0.1/tcp/4001
    /ip6/::1/tcp/4001
    /ip6/fc3d:9a4e:3c96:2fd2:1afa:18fe:8dd2:b602/tcp/4001

mapping peer id to available addrs

Fixes #439

[daviddias]

👍 yeah, that sounds good to me too :)

[dignifiedquire]

@diasdavid after some more thought, I actually realised we can just return an array of PeerInfo objects which contain the addrs, instead of a map. What do you think?

[daviddias]

@dignifiedquire I think that keeping the PeerInfo is indeed more powerful and we can always create the map at the CLI level to make the CLI expectation happy.

Have in mind though that a lot of these swarm commands will be strongly revisited with libp2p getting more primetime. In other words, what I mean is that if getting PeerInfo objs out of swarm addrs requires a ton of changes, better avoid that and just fulfil the API current expectation

[dignifiedquire]

equires a ton of changes, better avoid that and just fulfil the API current expectation

it's actually less code to do that, than the other change :)

[dignifiedquire]

Updated and done with

• feat(swarm): expose PeerInfo for addrs command ipfs-inactive/interface-js-ipfs-core#73
• feat(swarm): make interface-ipfs-core compliant ipfs-inactive/js-ipfs-http-client#380

[daviddias]

@dignifiedquire awesome 💯

Could you also add to this PR the CI tests (uncomment and verify they pass), please? Thank you!

[dignifiedquire]

@diasdavid they are uncommented?

[dignifiedquire]

@diasdavid all CI is green with the new versions

[daviddias]

@dignifiedquire sorry, typo, I meant the "CLI" tests here #489 (comment)

so that we are sure that jsipfs swarm <command>

[dignifiedquire]

@diasdavid enabled and fixed the tests :)