Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

chore: add ipfs http response package #3884

Merged
merged 102 commits into from
Sep 28, 2021

Conversation

vasco-santos
Copy link
Member

@vasco-santos vasco-santos commented Sep 21, 2021

This PR adds the content of https://github.com/ipfs/js-ipfs-http-response to this monorepo to smooth its maintenance burden.

This PR includes all the git contribution history and should be merged instead of squashed.

What's next?

vasco-santos and others added 30 commits May 22, 2018 15:58
The service-worker-gateway was only responding with the correct content-type for some mime-types, see https://github.com/sindresorhus/file-type#supported-file-types.
This commit now fall-backs to detecting based on the extension as well.

Note that SVGs aren't supported by the `file-type` module.
* feat: support cidv1b32 in resolver

- feat: CID support, added resolver.cid
- feat: basic support for HAMD sharded directory
  - not real support, we need ipfs.resolve for that
- fix: return data from raw dag without resolv step

License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
BREAKING CHANGE: v1 CIDs created by this module now default to base32 encoding when stringified

Not a direct dependency of this module but ipld-dag-pb changed the
case of some property names that are used by this module.

License: MIT
Signed-off-by: Alan Shaw <[email protected]>
@vasco-santos
Copy link
Member Author

yeah, I think I need to use the same think we did in unixfs with publishDirectory

@achingbrain
Copy link
Member

Maybe open this PR against the branch in #3879 - it's got all the CJS/ESM learnings from unixfs and ipfs-repo applied so will (hopefully) be less work to get another ESM module merged in.

It's a still a little rough rough the edges though.

@vasco-santos
Copy link
Member Author

oh wat, you are changing everything to ESM already 🎉 🎉 🚢 ❤️ ✈️

That's rad, yes, I will change the target

@vasco-santos vasco-santos changed the base branch from master to chore/switch-to-esm September 21, 2021 11:23
@vasco-santos
Copy link
Member Author

@achingbrain this will likely get problematic keeping the history of this commit and keeping this branch in sync with #3879

Should I just wait until that gets merged instead and then update master here?

@achingbrain
Copy link
Member

achingbrain commented Sep 21, 2021

That's probably the easiest way - I'm hoping to get #3879 in today or tomorrow.

Base automatically changed from chore/switch-to-esm to master September 22, 2021 11:37
@achingbrain
Copy link
Member

#3879 is in so merging master into this should make most of the red disappear.

@vasco-santos
Copy link
Member Author

Thanks! 🎉 I will look into it

@vasco-santos vasco-santos force-pushed the chore/add-ipfs-http-response-package branch from 8094dfb to d335628 Compare September 23, 2021 16:13
@vasco-santos vasco-santos force-pushed the chore/add-ipfs-http-response-package branch from 2f4cd6f to 654d84f Compare September 24, 2021 09:13
@vasco-santos
Copy link
Member Author

@achingbrain this is ready.

The commits should not be squashed, in order to keep repo history and contributors

@achingbrain achingbrain merged commit 7bac678 into master Sep 28, 2021
@achingbrain achingbrain deleted the chore/add-ipfs-http-response-package branch September 28, 2021 06:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants