Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat: upgrade to the new multiformats #3556

Merged
merged 36 commits into from
Jul 19, 2021
Merged

feat: upgrade to the new multiformats #3556

merged 36 commits into from
Jul 19, 2021

Conversation

vmx
Copy link
Member

@vmx vmx commented Feb 17, 2021

No description provided.

@vmx vmx force-pushed the js-dag-pb branch 2 times, most recently from f55e32d to 8802324 Compare March 12, 2021 18:08
@achingbrain achingbrain mentioned this pull request Apr 7, 2021
vmx and others added 7 commits April 24, 2021 15:05
This commits adds the BlockService directly to IPFS. It takes js-multiformats
CIDs as input and also returns new style blocks and no longer IpldBlocks.

It currently converts those CIDs and blocks into the legacy format, in order
to be compatible with the current ipfs-repo and ipfs-bitswap implementations.
In the future this kind of conversion will disappear, once the full stack is
using js-multiformats.
@achingbrain achingbrain changed the title chore: upgrade unixfs chore: upgrade to the new multiformats Jun 21, 2021
@achingbrain achingbrain changed the title chore: upgrade to the new multiformats feat: upgrade to the new multiformats Jul 19, 2021
@achingbrain achingbrain merged commit d13d15f into master Jul 19, 2021
@achingbrain achingbrain deleted the js-dag-pb branch July 19, 2021 11:04
@oed
Copy link
Contributor

oed commented Jul 26, 2021

Since this changes the underlaying nodejs version supported which has consequences for various build tooling, will the major version be bumped when this is released?

@achingbrain
Copy link
Member

The supported node versions are Current and Active LTS which at the time of writing are 14.x and 16.x.

CI is still run on these versions, the change you may be referring to here is switching what version the GH actions run on, which just do typechecking and report bundle size changes.

Where modules are 0.x.x the minor will be bumped, where they are x.x.x the major will be bumped, but this is because the constructor args have changed to accept IPLD codecs in place of ipld-formats, and the block API now accepts/returns Uint8Arrays in place of the { cid, data } tuple.

SgtPooki referenced this pull request in ipfs/js-kubo-rpc-client Aug 18, 2022
- Replaces the old [interface-ipld-format](https://github.com/ipld/interface-ipld-format) stack with the new [multiformats](https://github.com/multiformats/js-multiformats) stack.
- The Block API takes/returns `Uint8Array`s instead of [ipld-block](https://github.com/ipld/js-ipld-block) objects

BREAKING CHANGE: ipld-formats no longer supported, use multiformat BlockCodecs instead

Co-authored-by: Rod Vagg <[email protected]>
Co-authored-by: achingbrain <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants