This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: add mssing dag put and dag resolve cli commands
#2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also allows passing input to `ipfs-exec` to simulate piping in cli tests.
alanshaw
reviewed
Oct 17, 2019
src/cli/commands/dag/put.js
Outdated
| preload | ||
| }) | ||
|
|
||
| if (pin) { |
There was a problem hiding this comment.
We should push the pinning functionality into core so that it can take a gc lock to avoid being collected between adding and pinning.
There was a problem hiding this comment.
Or back out of pinning in this PR...
alanshaw
suggested changes
Oct 17, 2019
src/core/components/dag.js
Outdated
| await ipfs.pin.add(cid, { | ||
| lock: true | ||
| }) | ||
| } |
There was a problem hiding this comment.
We need to take the lock around the ipld.put and pin.add like we do in ipfs.add https://github.com/ipfs/js-ipfs/blob/master/src/core/components/files-regular/add-async-iterator.js#L58-L64
Note we'll need to call pin.add with lock: false in the same way we do with add.
alanshaw
approved these changes
Oct 17, 2019
hugomrdias
approved these changes
Oct 19, 2019
alanshaw
pushed a commit
to ipfs-inactive/interface-js-ipfs-core
that referenced
this pull request
Nov 11, 2019
Was added in ipfs/js-ipfs#2521 but not updated here.
alanshaw
pushed a commit
to ipfs-inactive/interface-js-ipfs-core
that referenced
this pull request
Nov 18, 2019
Was added in ipfs/js-ipfs#2521 but not updated here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also allows passing input to
ipfs-execto simulate piping in cli tests.