This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
RFC: allow passing constructor for the libp2p modules #1383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Context: allow overriding the libp2p modules, permitting this type of options:
Some libp2p modules require the peer id in the constructor. Instead of a fancy DI framework, I propose a simple solution that allows to pass a function that will act as a module constructor.
This could be made to be even more flexible, like, for instance, by allowing some transports to be passed as instances and others as a constructor, like this:
(What this doesn't solve is the transport -> discovery coupling, which sometimes may be required. I suggest this by adding
transport.discovery
to the list of discovery modules if it exists).I prefer this type of simplistic approach over some others that have been discussed, as this does not require libp2p module constructors to implement specific interfaces or require generic DI libs.