This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat(bitswap.unwatch) expose bitswap.unwatch to cli and http api #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Just realized I still have this configured to use my fork. Will fix this to go from local branch |
This was referenced Nov 25, 2023
This was referenced Jan 18, 2024
This was referenced May 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this mean we want to add a bitswap spec to interface-ipfs-core?
The go cli does not print anything on success as far as I can tell: https://github.com/ipfs/go-ipfs/blob/11ce0445cb24b6b99613223fc6d8128c6648a4df/core/commands/bitswap.go#L78
I can remove the print statement in this cli implementation and just test that no error happened instead if we want the output to match too.