This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Fix failing gateway tests with this one simple trick! #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
suggested changes
Sep 8, 2017
test/gateway/index.js
Outdated
| '/ipfs-' + Math.random().toString().substring(2, 8) + '-' + Date.now() | ||
| ) | ||
|
|
||
| http.api = new API(repoPath, { |
There was a problem hiding this comment.
This is incorrect, explanation why here -> #968 (comment)
There was a problem hiding this comment.
@diasdavid okay, Got it, I'll make sure tests are self-contained and don't use the local repo. Sorry for misunderstanding.
There was a problem hiding this comment.
No worries at all :) Thank you for working on the fix.
daviddias
approved these changes
Sep 8, 2017
daviddias
added a commit
that referenced
this pull request
Sep 8, 2017
* feat: add HTTP Gateway to the js-ipfs daemon License: MIT Signed-off-by: Yahya <[email protected]> * apply remaining CR * chore: update deps * test: fix failing gateway tests with this one simple trick! (#1006) * fix failing tests with this one simple trick! * adding files to make tests self-contained * changes requested by VictorBjelkholm #968 * chore: fix circle CI chrome build (#1008) (#1009) Thanks to mkg20001
dryajov
pushed a commit
that referenced
this pull request
Sep 12, 2017
* feat: add HTTP Gateway to the js-ipfs daemon License: MIT Signed-off-by: Yahya <[email protected]> * apply remaining CR * chore: update deps * test: fix failing gateway tests with this one simple trick! (#1006) * fix failing tests with this one simple trick! * adding files to make tests self-contained * changes requested by VictorBjelkholm #968 * chore: fix circle CI chrome build (#1008) (#1009) Thanks to mkg20001
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the failing tests in #968