Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

The "Explore the Ethereum Blockchain" is currently broken #1453

Closed
daviddias opened this issue Jul 19, 2018 · 9 comments
Closed

The "Explore the Ethereum Blockchain" is currently broken #1453

daviddias opened this issue Jul 19, 2018 · 9 comments
Assignees
Labels
ipld kind/bug A bug in existing code (including security flaws) kind/not-helia-issue P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@daviddias
Copy link
Member

daviddias commented Jul 19, 2018

Seems that some breaking changes have happened in DAG API / IPLD land that went uncaught.

@vmx do you know what changed? Can you look into this?

@daviddias daviddias added kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up labels Jul 19, 2018
@vmx
Copy link
Member

vmx commented Jul 19, 2018

Please give instructions on how to reproduce.

Things changed, but they shouldn't break things.

@vmx
Copy link
Member

vmx commented Jul 19, 2018

Oh, I guess you mean the example at examples/explore-ethereum-blockchain. I'll have a look.

@vmx vmx self-assigned this Jul 19, 2018
@vmx
Copy link
Member

vmx commented Jul 19, 2018

Works for me, here's what I did:

$ IPFS_PATH=/tmp/ethtest jsipfs init
initializing ipfs node at /tmp/ethtest
generating 2048-bit RSA keypair...done
peer identity: QmerPBKys7edagWswnSETLAqKgxHynttLdvMDXaxHQKgee
to get started, enter:

	jsipfs files cat /ipfs/QmfGBRT6BbWJd7yUc2uYdaUZJBbnEFvTqehPFoSMQ6wgdr/readme


$ IPFS_PATH=/tmp/ethtest ./load-eth-stuffs.sh
z43AaGEvwdfzjrCZ3Sq7DKxdDHrwoaPQDtqF4jfdkNEVTiqGVFW
z43AaGEywSDX5PUJcrn5GfZmb6FjisJyR7uahhWPk456f7k7LDA
z43AaGF42R2DXsU65bNnHRCypLPr9sg6D7CUws5raiqATVaB1jj
z45oqTS2AQ9SgyVa31LRGZgfibtdoPvP2miMNaXbDLLgD9MdAAr
z45oqTS8wZaNGU2eepKHRbXvmV93cKQbiL241RB3bRtMYZP8hNm
z45oqTS8wZaNGU2eepKHRbXvmV93cKQbiL241RB3bRtMYZP8hNm
z45oqTS4E1GeJujnKVJG3xSVnS64A8mMCWhKSkCWACNCeD95mtQ
z45oqTS4MnurEeEaanvFieeJDNHH3jGNk9NJEiyrwXwYQSWfxUB
z45oqTRwExySeMeivsU1Y9UdzWDp2mx71TtQhmTGzRaXCcsNujj
z45oqTRzb9a5xyvx5RbfSXH1K5jibyZ4AxnXyYReuLw7KU5veYw
$ IPFS_PATH=/tmp/ethtest jsipfs dag get z43AaGEvwdfzjrCZ3Sq7DKxdDHrwoaPQDtqF4jfdkNEVTiqGVFW/
=�{���"D�*��p�_�o!��-�K�p�;N,�M���]z���g����E�t�B�@ԓG,�gO���������j�qk���,O��T�+SA�~@!&�>i(
                                                                                           ��
�������,V�U���E���n[H�l��b/��c�!,c3��H.�^/g�v�l
                                               �{��Li�m
                                                       TղG,  ,r�|:�,0%,=	!,?�,X�)�,ethermine - US1,i�k^��Z�C/ĘsQ[�7zu]�(t�7,�d�sn�
$ IPFS_PATH=/tmp/ethtest jsipfs dag get z43AaGEvwdfzjrCZ3Sq7DKxdDHrwoaPQDtqF4jfdkNEVTiqGVFW/parentHash
0x3dec047bc8e0dc2218449e2a0487ca70b95fb56f218d942d824b029f70893b4e

Hence I close this issue. @diasdavid If you don't think it works as expected, please provide details.

@vmx vmx closed this as completed Jul 19, 2018
@daviddias daviddias reopened this Jul 19, 2018
@daviddias
Copy link
Member Author

@vmx check the experience described on https://github.com/ipfs/go-ipld-eth/blob/master/plugin/README.md

@vmx
Copy link
Member

vmx commented Jul 20, 2018

@diasdavid Can you please provide more information? Did it work in the past? Which parts of the document you linked do you expect to work (e.g. there's not dag put in jsipfs yet)? What are the steps to reproduce?

@vmx vmx removed their assignment Jul 20, 2018
@alanshaw alanshaw added the status/ready Ready to be worked label Aug 7, 2018
@daviddias daviddias added the ipld label Oct 1, 2019
@daviddias daviddias reopened this Oct 2, 2019
@daviddias
Copy link
Member Author

#1453 (comment)

The first dag get returns a buffer, rather than a human readable json blob

(e.g. there's not dag put in jsipfs yet)?

Why not? What's missing to get it?

@achingbrain
Copy link
Member

there's not dag put in jsipfs yet

I must be reading this wrong. It's here in core and here in ipfs-http-client.

@daviddias
Copy link
Member Author

@achingbrain it's not on the CLI, which is what go is using to showcase its demos.

@SgtPooki
Copy link
Member

js-ipfs is being deprecated in favor of Helia. You can #4336 and read the migration guide.

Please feel to reopen with any comments by 2023-06-02. We will do a final pass on reopened issues afterwards (see #4336).

FYI that we're removing the ethereum block from explore.ipld.io because it's not being served on IPFS anymore.. see ipld/explore.ipld.io#74

If you have a good example of an ethereum block that we should be able to render on explore.ipld.io please open an issue in the ipfs/ipld-explorer-components repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ipld kind/bug A bug in existing code (including security flaws) kind/not-helia-issue P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants