feat: encode record-store keys in pubsub #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Nov 16, 2018
|
@Stebalien will test it with |
vasco-santos
force-pushed
the
feat/encode-record-store-keys
branch
from
dc10da5
to
7c6f648
Compare
ghost
assigned
vasco-santos
force-pushed
the
feat/encode-record-store-keys
branch
from
7c6f648
to
07a824d
Compare
vasco-santos
force-pushed
the
feat/encode-record-store-keys
branch
from
07a824d
to
e20dcac
Compare
This was referenced Nov 22, 2018
|
It is working locally for me. Details on ipfs/interop#39#issuecomment-441068921 |
alanshaw
requested changes
Nov 26, 2018
alanshaw
approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiming to fix the interop problem described in ipfs/interop#39, as well as following the same approach as libp2p/go-libp2p-pubsub-router#17.
This will unblock ipfs/js-ipfs#1559 and ipfs/interop#39.