Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update translations #242

Closed
bertrandfalguiere opened this issue May 27, 2020 · 3 comments · Fixed by #245
Closed

Update translations #242

bertrandfalguiere opened this issue May 27, 2020 · 3 comments · Fixed by #245
Labels
effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@bertrandfalguiere
Copy link

This module is used in webUI, which is used is IPFS Desktop. Significant additions have been made in several languages (German, Italian, French at least, possibly Chinese), and they missed the IPFS Desktop 11 realease.
This shows that updating translations of this component is not in the release process of IPFS Desktop (I'll open an issue for that).
I would be great if they could be ready for when go-ipfs 0.6 triggers a new IPFS Desktop release.
@bertrandfalguiere bertrandfalguiere added the need/triage Needs initial labeling and prioritization label May 27, 2020
@bertrandfalguiere bertrandfalguiere mentioned this issue May 27, 2020
Closed
@bertrandfalguiere
Copy link
Author

Issue already exists: ipfs/ipfs-webui#1370

@jessicaschilling
Copy link
Contributor

Ref ipfs/ipfs-webui#1477 (comment) -- @lidel and/or @rafaelramalho19, is there bandwidth to include this work in the next release?

@jessicaschilling jessicaschilling added exp/intermediate Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked and removed need/triage Needs initial labeling and prioritization labels May 27, 2020
@bertrandfalguiere bertrandfalguiere mentioned this issue May 27, 2020
Closed
@lidel
Copy link
Member

lidel commented May 28, 2020 •
edited
Loading

Ugh, I was under impression that if we ship latest translations with webui:
https://github.com/ipfs-shipyard/ipfs-webui/blob/master/public/locales/fr/explore.json
we won't need to do a new release of this module, but @bertrandfalguiere is right, translations are not picked up(!)

How to reproduce

I can confirm that the latest webui it does not load French translation of IPLD Explorer screen. To reproduce: try setting Settings → Language → French at https://webui.ipfs.io

Note that it loads https://webui.ipfs.io/locales/fr/explore.json which includes translations, but does not display them, so its a bug.

Initial ideas

I won't have bandwidth to look into this deeper this week, but here are some thoughts:

  • Perhaps a breaking change in i18next libs? AFAIK the latest webui and the last release of this module use different versions in package.json.
    • Using the same dependency versions as in webui would be the first thing to try.
    • Looking at i18next console output in dev could also help.
    • @rafaelramalho19 if you could check if aligning libs solves the problem, we could ship this as bugfix in webui v2.9.1 and might squeeze into go-ipfs 0.6, if its more complex, then it needs to wait until 0.7 :(
  • We are missing regression tests for this.
    • Disabling dependency bot would help in avoiding regressions until we have tests.

@jessicaschilling jessicaschilling mentioned this issue Jun 2, 2020
Merged
@lidel lidel mentioned this issue Jun 3, 2020
Merged
@lidel lidel closed this as completed in #245 Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/days Estimated to take multiple days, but less than a week exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(i18): correctly load all translations ipfs/ipld-explorer-components
3 participants
@lidel @jessicaschilling @bertrandfalguiere