-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show as many node links as height allows #238
Conversation
Stray semicolon
Hi @lidel, @rafaelramalho19, @hacdias - you were the last folks to commit against this repo, so hoping one of you might be able to take a quick look. This solves ipld/explore.ipld.io#53, but not sure if it's a legit approach. Thanks! |
Have you tried using AutoSizer? https://github.com/bvaughn/react-virtualized/blob/master/docs/usingAutoSizer.md |
This is a bit odd. The way this component is set up, it's already using I'm not sure about the reasons behind the original decision to do this ... but the extra
@lidel @rafaelramalho19 thoughts? |
I would advise just merging this as it is and refactoring in the future. I guess we have lots of stuff to perfect and iterate on ipld-explorer in the months after the pinning work is done 🤔 |
babel output made connect-deps connect to fail, this fixes it, enabling us to tests the component locally, in a real webui License: MIT Signed-off-by: Marcin Rataj <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Just to be sure, I tested this in real, local versions of both explore.ipld.io website and ipfs-webui.
- Looks 👌 in both, thank you @jessicaschilling!
- Made a small fix that made it work with connect-deps tool, which prooved to be more reliable than built-in
link
innpm
andyarn
- I agree we should ship this – I'm merging this PR, and will do the translations + NPM release tomorrow.
@lidel thank you!!! 🌞🌞 |
Not sure if this is too hacky a suggestion, but enables full-height link tables by way of nesting
math
:tableHeight
is the greater of either 370px or (the lesser of either "window height less page header height" or "the number of rows x row height plus table header height")Note that 370px is the current max height.
Closes ipld/explore.ipld.io#53.