refactor(test): switch e2e to @playwright/test #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The below error was happening for almost every single file on `npm run build`: Line 0: Parsing error: require() of ES Module /Users/sgtpooki/code/work/protocol.ai/ipfs/webui/node_modules/eslint/node_modules/eslint-scope/lib/definition.js from /Users/sgtpooki/code/work/protocol.ai/ipfs/webui/node_modules/babel-eslint/lib/require-from-eslint.js not supported. Instead change the require of definition.js in /Users/sgtpooki/code/work/protocol.ai/ipfs/webui/node_modules/babel-eslint/lib/require-from-eslint.js to a dynamic import() which is available in all CommonJS modules
lidel
force-pushed
the
1981-chore-install-missing-dependencies
branch
from
bdbd601
to
4106886
Compare
This removes deprecated jest-playwright which caused issues with latest dependencies. E2E are now pure playwright, which reduces the surface for bugs and should be more stable and easier to maintain in general.
lidel
force-pushed
the
1981-chore-install-missing-dependencies
branch
from
4106886
to
bcaa612
Compare
lidel
changed the title
lidel
approved these changes
Jul 25, 2022
There was a problem hiding this comment.
I took a stab at fixing E2E tests in this PR and ended up removing jest-playwright and replacing it with @playwright/test (we did something similar in ipfs-desktop a while ago):
It simplified things a lot, and restored CID to be green again.
Updated the title to this PR to reflect the change, and decouple it from #1981
This was referenced Jul 25, 2022
Merged
|
🎉 This PR is included in version 2.18.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially helps with #1981
Unblocks #1804