Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing ReleaseLink in go-ipfs version #1865

Merged
merged 1 commit into from
Oct 15, 2021
Merged

fix: missing ReleaseLink in go-ipfs version #1865

merged 1 commit into from
Oct 15, 2021

Conversation

xrazis
Copy link
Contributor

@xrazis xrazis commented Oct 14, 2021

Closes #1864

I chose to alter the if statement instead of adding another one. That way if in the future a provider needs to be added (say for example rust-ipfs), then you can simple append that URL to the providers object, only changing code in one place.

@welcome

This comment has been minimized.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lidel lidel merged commit dfd4c9a into ipfs:main Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing ReleaseLink in go-ipfs version
2 participants