fix: make quitAndInstall work on macos #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gotta clear all listeners on all the windows for quitAndInstall to work. Now auto-update works as expected on mac. thanks to the proposed fix on this issue: electron-userland/electron-builder#1604 (comment) License: MIT Signed-off-by: Oli Evans <[email protected]>
ghost
assigned 
|
I'm still testing this out, as i think IFPS shutdown time can still prevent it from working. |
License: MIT Signed-off-by: Oli Evans <[email protected]>
olizilla
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gotta clear all listeners on all the windows for quitAndInstall
to work. Now auto-update works as expected on mac.
thanks to the proposed fix on this issue:
electron-userland/electron-builder#1604 (comment)
fixes: #851
License: MIT
Signed-off-by: Oli Evans [email protected]