fix: startup on Debian 10 #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
force-pushed
the
fix/sandbox-on-debian-10
branch
from
f1e5689 to
2ec7924
Compare
lidel
commented
Mar 10, 2020
| @@ -58,8 +58,8 @@ | |||
| "cross-env": "^6.0.3", | |||
| "delay": "^4.3.0", | |||
| "dirty-chai": "^2.0.1", | |||
| "electron": "^7.1.11", | |||
| "electron-builder": "^22.3.2", | |||
| "electron": "^7.1.14", | |||
There was a problem hiding this comment.
I did not update to 8.x because it does not support old school Tray icons on Linux (#1153) and i did not want to open a second can of worms in one day.
autonome
suggested changes
Mar 10, 2020
This disables sandboxing in ipfs-desktop.desktop manifest which is ised by Desktop Environments for generating menus and icons used for starting apps. Rationale can be found at: #1362 (comment) License: MIT Signed-off-by: Marcin Rataj <[email protected]>
lidel
force-pushed
the
fix/sandbox-on-debian-10
branch
from
2ec7924 to
87475d4
Compare
lidel
commented
Mar 10, 2020
Comment on lines
+180
to
+192
| ```console | ||
| $ ipfs-desktop | ||
| $Trace/breakpoint trap | ||
| ``` | ||
|
|
||
| This is a known issue with Electron/Chrome and some hardened kernels. | ||
| If you are interested in details, read [this](https://github.com/ipfs-shipyard/ipfs-desktop/issues/1362#issuecomment-596857282). | ||
|
|
||
| The only reliable way to fix this at the moment is to start the app with additional parameter: | ||
|
|
||
| ```console | ||
| $ ipfs-desktop --no-sandbox | ||
| ``` |
There was a problem hiding this comment.
Updated troubleshooting section contains a single, clear advice now,
and is aligned with what we do in .desktop manifest.
|
Merging to unblock release, we can tweak troubleshooting in README in separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes startup on Debian 10 and any other distribution with strict / b0rked Chromium sandbox setup.
We set
executableArgsto--no-sandboxinelectron-builder.yml.It will update
Execcommand inipfs-desktop.desktopmanifest that is run when menu item / icon in desktop environment is clicked.Motivation
App does not start on Debian 10 due to sandboxing FUBAR.
Details in #1362 (comment))
Note: this should be acceptable for this app.
Electron is used only for tray (ha, #1153) menu, the GUI for starting/stopping daemon. Actual IPFS node is a golang binary running in separate process.