fix: move IPFS_PATH to ~/.ipfs-desktop

[hacdias]

This fixes the issue caused by having IPFS_PATH in the same directory as the app code. That would fail in multiple circumstances:

1. When the app was updated, IPFS_PATH would get deleted.
2. macOS gatekeeper paths randomization for security purposes creates a read-only directory for the app files when the app isn't executed from secure locations (such as ~/Applications) and it would make it fail.

Closes #1077.

License: MIT
Signed-off-by: Henrique Dias [email protected]

[lidel]

Why do we store IPFS_PATH in a text file?

path is already present in config.json:

https://github.com/ipfs-shipyard/ipfs-desktop/blob/34077078d97d2528c8b28b76ff3731c71a92439e/src/common/store.js#L12

And it gets updated during the move:

https://github.com/ipfs-shipyard/ipfs-desktop/blob/e8d947a950b7fdd69102f6e8e1ef76163a5dab15/src/move-repository-location.js#L75-L76

I feel I am missing something here.

[hacdias]

@lidel for the same reason we did it initially: on ipfs.sh and ipfs.cmd we don't know where config.json is and even if we did, we'd need to parse JSON, which wouldn't get easy to get cross-platform

[lidel]

Ok, this PR works as expected on Linux.

Digression: I am worried this separate file will produce bugs in the long run. Additional code is required to keep it in sync with config.json and we need to remember about it. This concern should not block this PR form being merged, just something to think about :)

[yeehi]

@hacdias @lidel
There seems to be no way to choose the folder for .ipfs/blocks using the GUI in ipfs-desktop. If you install ipfs-desktop using an appimage, you can't readily change this setting from the command line. By default, the data folder goes into your system drive, and that can fill up rapidly.

I hope that we can a) be prompted where to set this important, potentially large folder when ipfs-desktop is first launched b) accomplish this with the ipfs-dekstop GUI.