Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease package sizes #1659

Closed
3 tasks done
lidel opened this issue Oct 2, 2020 · 0 comments · Fixed by #1660
Closed
3 tasks done

Decrease package sizes #1659

lidel opened this issue Oct 2, 2020 · 0 comments · Fixed by #1660
Labels
need/triage Needs initial labeling and prioritization

Comments

@lidel
Copy link
Member

lidel commented Oct 2, 2020

Our packages ballooned in size:

  • ipfs-desktop-0.12.2-linux-x64.tar.xz 77.6 MB
  • ipfs-desktop-0.13.0-linux-x64.tar.xz - 295 MB

The main offender is app.asar, which in the past had similar size to app.asar.unpacked:

ipfs-desktop-0.12.2-linux-x64/resources:
   57.3 MiB [##########]  app.asar
   52.6 MiB [######### ] /app.asar.unpacked

and now seems to have more than it should:

ipfs-desktop-0.13.0-linux-x64/resources:
  264.8 MiB [##########]  app.asar
   56.7 MiB [##        ] /app.asar.unpacked

For some reason app.asar includes entire project root, not just node_modules/go-ipfs

Need to look into both, and see if we can make it smaller.

  • perhaps there is a bug in latest electron-builder
  • maybe we introduced a regression in feat(ci): move to GitHub Actions #1657?
    • kinda. we introduced .cache directory, it is in .gitignore but electron-builder has its own list.
      • will PR a fix shortly
  • do we need both? (we effectively have two copies of go-ipfs.. why?)
    • I believe only unpacked version is used, because we want to have standalone ipfs[.exe] binary that could be used on PATH
    • It should be possible to exclude it from asar archive and add it back manually + adjust path (ideally, keep it the same), so only one copy is included (will save us 50MB+)
@lidel lidel added the need/triage Needs initial labeling and prioritization label Oct 2, 2020
lidel added a commit that referenced this issue Oct 2, 2020
Closes #1659 but we still bundle go-ipfs binary twice

License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
lidel added a commit that referenced this issue Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant