Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: OS-level protocol handler (Ubuntu/Windows): opens the app but does nothing #1549

Closed
ghost opened this issue Jun 14, 2020 · 9 comments · Fixed by #2832
Closed

bug: OS-level protocol handler (Ubuntu/Windows): opens the app but does nothing #1549

ghost opened this issue Jun 14, 2020 · 9 comments · Fixed by #2832
Labels
area/linux Linux area/windows Windows help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) need/analysis Needs further analysis before proceeding P1 High: Likely tackled by core team if no one steps up

Comments

@ghost
Copy link

ghost commented Jun 14, 2020

(They're also hiding the IPFS link with Javascript, but that's a different problem)

To Reproduce
Steps to reproduce the behavior:
Open dweb://ipfs/QmSDPa5pfSNCxnKv2ybFio2oKvndX6hCbtmg7NNbNhraHe/BeOS%205.0%20Professional.7z in Firefox after installing the ipfs-desktop client via dpkg
image
Click on 'Open Link'

App opens but there's no feedback
image

Expected behavior
Some kind of feedback: "File added", "File unavailable", whatever.

** Sidenote **

Your template here says this:

ATTACH LOGS

If possible:
1. Go to `Advanced` → `Open Logs Directory`
2. Find `*.log` files
3. Attach `error.log` and `combined.log` to this issue.

But there doesn't seem to be an 'Advanced' anywhere in the UI.

@ghost ghost added the need/triage Needs initial labeling and prioritization label Jun 14, 2020
@jessicaschilling
Copy link
Contributor

@lidel @rafaelramalho19 or @olizilla -- might you be able to triage? Thank you!

@olizilla
Copy link
Member

olizilla commented Jul 1, 2020

@voltagex thanks for this detailed report! I'll take a look. Thanks for the note about the issue template too. The advanced menu is only accessible on linux flavours that show a dock / task bar icon like thing. We need a solution for that too, see #1153

@lidel lidel added area/linux Linux kind/bug A bug in existing code (including security flaws) help wanted Seeking public contribution on this issue need/analysis Needs further analysis before proceeding P2 Medium: Good to have, but can wait until someone steps up and removed need/triage Needs initial labeling and prioritization labels Aug 11, 2020
@lidel lidel changed the title Using a dweb link opens the app but doesn't seem to do anything OS-level protocol handler on Ubuntu: opens the app but does nothing Oct 12, 2020
@lidel
Copy link
Member

lidel commented Oct 12, 2020

@voltagex is this still a problem on Ubuntu after you update to v0.13.2?

@lidel lidel added the need/author-input Needs input from the original author label Oct 12, 2020
@ghost
Copy link
Author

ghost commented Oct 12, 2020 via email

@ghost
Copy link
Author

ghost commented Oct 15, 2020

Getting back to this - yes, there's still no indication that anything happened with the link on v0.13.2.

@ghost
Copy link
Author

ghost commented Oct 15, 2020

@lidel I can also reproduce this on Windows. After installing the desktop app and using the dweb link I originally posted, I get this:
image

It's not easy for me to take an Ubuntu screenshot, but it's not blank there (still no feedback though)

@lidel lidel added area/windows Windows P1 High: Likely tackled by core team if no one steps up and removed P2 Medium: Good to have, but can wait until someone steps up labels Oct 15, 2020
@lidel
Copy link
Member

lidel commented Oct 15, 2020

Thank you @voltagex! This is very useful.

We will prioritize fix for this, could be done as a part of #1646

@lidel lidel added need/triage Needs initial labeling and prioritization and removed need/author-input Needs input from the original author labels Oct 15, 2020
@lidel lidel changed the title OS-level protocol handler on Ubuntu: opens the app but does nothing OS-level protocol handler (Ubuntu/Windows): opens the app but does nothing Oct 15, 2020
@lidel lidel added this to the v0.16 milestone May 5, 2021
@lidel lidel removed the need/triage Needs initial labeling and prioritization label May 14, 2021
@lidel lidel modified the milestones: v0.16, v0.19 Jan 17, 2022
@hacdias hacdias self-assigned this Jan 28, 2022
@hacdias
Copy link
Member

hacdias commented Jan 28, 2022

An update on this: I will work on #1646 and then debug this on a Linux and Windows VM. It seems to be working well on macOS. If anyone is having issues on macOS too, please let me know.

@lidel lidel removed this from the v0.19 milestone Mar 3, 2022
@SgtPooki
Copy link
Member

SgtPooki commented Jul 3, 2023

i just tested this by visiting the following URLs in safari on macOS, and while I get the prompt to open in ipfs-desktop, I do not see anything happen in IPFS desktop:

  • dweb://ipfs/QmdmQXB2mzChmMeKY47C43LxUdg1NDJ5MWcKMKxDu7RgQm
  • dweb://ipfs/QmSDPa5pfSNCxnKv2ybFio2oKvndX6hCbtmg7NNbNhraHe/BeOS%205.0%20Professional.7z
  • dweb://ipfs/QmSnuWmxptJZdLJpKRarxBMS2Ju2oANVrgbr2xWbie9b2D
  • dweb://ipfs/QmQi7RK4b7GckY56yKWUmR5ET4fq7z6ppRZ1nXbKN9P9Ss?filename=Asset%202.png -- have locally

@SgtPooki SgtPooki changed the title OS-level protocol handler (Ubuntu/Windows): opens the app but does nothing bug: OS-level protocol handler (Ubuntu/Windows): opens the app but does nothing Jul 3, 2023
@hacdias hacdias removed their assignment May 27, 2024
@lidel lidel mentioned this issue Jun 13, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/linux Linux area/windows Windows help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) need/analysis Needs further analysis before proceeding P1 High: Likely tackled by core team if no one steps up
Projects
No open projects
Status: Needs Grooming
Development

Successfully merging a pull request may close this issue.

5 participants