Skip to content

Commit

Permalink
chore: macOS notarizing
Browse files Browse the repository at this point in the history
This adds scripts that run electron-notarize
as additional manual or build steps on darvin runtime, loosly following
https://kilianvalkhof.com/2019/electron/notarizing-your-electron-application/

Context:
#1211

License: MIT
Signed-off-by: Marcin Rataj <[email protected]>
  • Loading branch information
lidel committed Mar 10, 2020
1 parent 7b3c49b commit bbf04e5
Show file tree
Hide file tree
Showing 8 changed files with 230 additions and 33 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ node_modules
out
dist
.cache
.env
config.gypi
assets/webui
*.nupkg
Expand Down
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,9 @@ Other languages are periodically pulled from [Transifex](https://www.transifex.c
- Publish local changes and the tag to GitHub repo: `git push && git push origin vA.B.C`
- Wait for the CI to upload the binaries to the draft release (a new one will be created if you haven't drafted one).
- The `latest.yml, latest-mac.yml, latest-linux.yml` files on the release are used by the app to determine when an app update is available. Once a release is published, users should recieve the app update. See: https://www.electron.build/auto-update.
- Notarize `.dmg` at Apple (context: [#1365](https://github.com/ipfs-shipyard/ipfs-desktop/issues/1211))
1. Download `.dmg` from `https://github.com/ipfs-shipyard/ipfs-desktop/releases/vA.B.C`
2. Run `node pkgs/macos/notarize-cli.js ./IPFS-Desktop-A.B.C.dmg`
- Update [Homebrew Cask](https://github.com/Homebrew/homebrew-cask/blob/master/CONTRIBUTING.md#updating-a-cask).
- Update Chocolatey package:
1. Update the version number on [ipfs-desktop.nuspec](./pkgs/chocolatey/ipfs-desktop.nuspec#L5)
Expand Down
6 changes: 6 additions & 0 deletions electron-builder.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,15 @@ directories:

asarUnpack: 'out/**/scripts/**/*'

afterSign: './pkgs/macos/notarize-build.js'

mac:
category: public.app-category.utilities
darkModeSupport: true
hardenedRuntime: true
gatekeeperAssess: false
entitlements: './pkgs/macos/entitlements.mac.plist'
entitlementsInherit: './pkgs/macos/entitlements.mac.plist'

dmg:
iconSize: 160
Expand Down
Loading

0 comments on commit bbf04e5

Please sign in to comment.