-
Notifications
You must be signed in to change notification settings - Fork 864
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This runs electron-notarize as additional step on darvin runtime, loosly following https://kilianvalkhof.com/2019/electron/notarizing-your-electron-application/ This is work in progress (I have no Mac, so we need to use CI) Context: #1211 License: MIT Signed-off-by: Marcin Rataj <[email protected]>
- Loading branch information
Showing
6 changed files
with
49 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ node_modules | |
out | ||
dist | ||
.cache | ||
.env | ||
config.gypi | ||
assets/webui | ||
*.nupkg | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
<plist version="1.0"> | ||
<dict> | ||
<key>com.apple.security.cs.allow-unsigned-executable-memory</key> | ||
<true/> | ||
</dict> | ||
</plist> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
require('dotenv').config() | ||
const { notarize } = require('electron-notarize') | ||
|
||
exports.default = async function notarizing (context) { | ||
const { electronPlatformName, appOutDir } = context | ||
if (electronPlatformName !== 'darwin') return | ||
// TODO: ensure we notarize only master and release tags | ||
|
||
const appName = context.packager.appInfo.productFilename | ||
|
||
return notarize({ | ||
appBundleId: 'io.ipfs.desktop', | ||
appPath: `${appOutDir}/${appName}.app`, | ||
// TODO: figure out how to get credentials ( https://github.com/electron/electron-notarize#method-notarizeopts-promisevoid) | ||
// Q: use user & pass (below) or appleApiKey & appleApiIssuer? | ||
appleId: process.env.APPLEID, // TODO: set this on CI? | ||
appleIdPassword: process.env.APPLEIDPASS // TODO: set this on CI? it needs to be app-specific, generated on https://appleid.apple.com/ | ||
|
||
}) | ||
} |