wip: remove redundant binary

License: MIT Signed-off-by: Marcin Rataj <[email protected]>
ipfs · Sep 30, 2020 · 22647e8 · 22647e8
1 parent 13bb67d
commit 22647e8
Show file tree

Hide file tree

Showing 3 changed files with 258 additions and 115 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -11,7 +11,7 @@ jobs:
     strategy:
       matrix:
         # TODO: remove Travis and add linux and macOS
-        os: [windows-2019]
+        os: [windows-latest]
 
     steps:
       - name: Check out Git repository
@@ -25,22 +25,22 @@ jobs:
       - name: Install dependencies
         run: npm ci
       - name: Test
-        run: npm run test
+        run: echo TODO # npm run test
       - name: Test End-to-end
         run: echo TODO #npm run test:e2e
       - name: Lint
-        run: npm run lint
+        run: echo TODO # npm run lint
       - name: Build
         run: echo TODO # npm run build
 
       - name: Build binaries with electron-builder
         uses: samuelmeuli/action-electron-builder@92327c67bc45ff7c38bf55d8aa8c4d75b7ea38e7 # v1.6.0 but safer than a tag that can be changed
         with:
-          max_attempts: 2
+          release: false # keep it as draft for manual inspection  TODO ${{ startsWith(github.ref, 'refs/tags/v') }}
+          max_attempts: 1
+          debug: electron-builder
+          # TODO: args: --publish onTag
+          # TODO: secrets for mac, snap, chocolatey
           github_token: ${{ secrets.github_token }}
           windows_certs: ${{ secrets.windows_certs }}
           windows_certs_password: ${{ secrets.windows_certs_password }}
-          # TODO: secrets
-          # If the commit is tagged with a version (e.g. "v1.0.0"),
-          # release the app after building
-          release: ${{ startsWith(github.ref, 'refs/tags/v') }}