This repository has been archived by the owner on Sep 9, 2021. It is now read-only.
feat: add class-is module #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
2 tasks
daviddias
approved these changes
Oct 7, 2018
alanshaw
approved these changes
Oct 15, 2018
alanshaw
suggested changes
Oct 15, 2018
There was a problem hiding this comment.
There are a number of occasions in this file where we're accessing the non-wrapped Key class:
These all need to be changed otherwise they create Key objects that don't have the '@ipfs/interface-datastore/key' symbol and so aren't considered to be instances of Key when used with Key.isKey.
|
@alanshaw just fixed your review. Thanks! |
alanshaw
approved these changes
Oct 17, 2018
|
@pgte can you drive this merge and get it released? |
|
@vasco-santos could you please rebase from master? |
vasco-santos
force-pushed
the
feat/add-class-is-module
branch
from
ac11b5e
to
3cc97b3
Compare
|
Rebased @pgte ! |
vasco-santos
force-pushed
the
feat/add-class-is-module
branch
from
3cc97b3
to
5a377ed
Compare
|
Landed on v0.6.0. |
alanshaw
pushed a commit
to ipfs/js-ipfs
that referenced
this pull request
Oct 29, 2018
As `instance of` fails using different versions of a module, it was changed to use `class-is`. Needs: - [x] [js-peer-id#84](libp2p/js-peer-id#84) - [x] [interface-datastore#24](ipfs/interface-datastore#24) Fixes #1615
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
instance offails when using different versions of a module. This way, we end up with problems using this in other places, such as js-ipfs/core/ipns/publisher.js#L93.In the context of js-ipfs/issues/1615