This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
Size-based unsharding #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
reviewed
Jun 7, 2021
aschmahmann
reviewed
Jun 7, 2021
schomatis
commented
Jun 16, 2021
schomatis
commented
Jun 20, 2021
schomatis
force-pushed
the
schomatis/directory/unsharding
branch
from
8223156
to
068bcdd
Compare
This comment has been minimized.
This comment has been minimized.
schomatis
force-pushed
the
schomatis/directory/unsharding
branch
from
068bcdd
to
3301178
Compare
This comment has been minimized.
This comment has been minimized.
aschmahmann
suggested changes
Jul 29, 2021
There was a problem hiding this comment.
Thanks and sorry for the late review. It looks like there are still a number of FIXMEs in the PR which are needed pre-merge. I commented on the ones where it looks like you had questions, but if there are more please tag me.
It looks like the tests for this PR are split between here and #99. Which would you like me to take a look at? Should #99 be rebased on this PR (or just merged in?).
@Stebalien I left some comments/questions for you when convenient. Before we do the final merge here though I'll want another set of eyes.
This was referenced Jul 30, 2021
schomatis
force-pushed
the
schomatis/directory/unsharding
branch
from
a5cc9db
to
2f8574e
Compare
This was referenced Aug 3, 2021
Stebalien
reviewed
Aug 11, 2021
aschmahmann
suggested changes
Aug 12, 2021
8 tasks
Co-authored-by: Adin Schmahmann <[email protected]>
Co-authored-by: Adin Schmahmann <[email protected]>
* fix(dir): remove timeout and evaluate switch *before* removing entry * BLOCKING: temporary fix * remove Shard cid not used and not maintained * update blocking readme * resolve FIXME * fix: add back concurrent option in dag.walk * decouple switch from directory downgrade
- Add tests for automatic unsharding - Modified some internals to be sufficiently extensible for testing
schomatis
force-pushed
the
schomatis/directory/unsharding
branch
from
51cb5fe
to
9ea81f2
Compare
* feat: use custom dag traversal for HAMT link enumeration * fix comments in completehamt_test.go Co-authored-by: Lucas Molas <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update 8/26: Working on tests in #99. Moving minor changes for last in #105.
Working on tests in separate PR (to be merged on top of this one): #99.
Review in progress.
Most important items to address:
sizeBelowThresholdloop. Remove tiemout and refactor sizeBelowThreshold #102AddEntrycase: . Add unsharding logic for the AddChild case as well #103switchToBasicfunction in unsharding PR #101.