This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
feat: add UpgradeableDirectory #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
May 6, 2021
| // if we should switch to HAMTDirectory according to global option(s). | ||
| func (d *UpgradeableDirectory) AddChild(ctx context.Context, name string, nd ipld.Node) error { | ||
| if UseHAMTSharding { | ||
| if basicDir, ok := d.Directory.(*BasicDirectory); ok { |
There was a problem hiding this comment.
nit: check both types and fail if we have some strange third type.
There was a problem hiding this comment.
ok, will address in upcoming PR, i already have some commits on top of this code
There was a problem hiding this comment.
(note: for me, "nit" means "I don't really care but I had this random thought while reading this code"; totally optional)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward ipfs/go-mfs#86.
To avoid breaking compatibility we change as little as possible here but probably both
HAMTDirectoryandBasicDirectoryshould be made private. (In that case we would exportSwitchToShardingfromBasicDirectoryto theUpgradeableDirectory.)