-
Notifications
You must be signed in to change notification settings - Fork 53
correct file size for raw node #88
correct file size for raw node #88
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
return pbdata.GetFilesize(), nil | ||
case pb.Data_Symlink, pb.Data_Raw: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Raw types, data 0 bytes in the data section, but the filesize is set.
i.e.
Type:Raw Data:"" filesize:114178 blocksizes:114178
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…filesize-raw correct file size for raw node This commit was moved from ipfs/go-unixfs@a20f6cb
…filesize-raw correct file size for raw node This commit was moved from ipfs/go-unixfs@a20f6cb
While looking at ipfs/kubo#7916 I noticed the file size returned by https://github.com/ipfs/go-ipfs/blob/master/core/commands/get.go#L80 is 0 for this raw dag.