This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
Fix HAMT enumeration for in-memory traversal #110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schomatis
force-pushed
the
schomatis/fix/enumlinks-from-memory
branch
from
820c49d
to
b8b11b3
Compare
schomatis
commented
Oct 27, 2021
Comment on lines
-377
to
+381
| rootNode, err := ds.Node() | ||
| if err != nil { | ||
| emitResult(ctx, linkResults, format.LinkResult{Link: nil, Err: err}) | ||
| return | ||
| } | ||
| err = dag.Walk(ctx, getLinks, rootNode.Cid(), cset.Visit, dag.Concurrent()) | ||
| err := dag.Walk(ctx, getLinks, packBytesIntoCID(nil), cset.Visit, dag.Concurrent()) |
There was a problem hiding this comment.
Note removal of serialization here. Will add an explicit test.
schomatis
commented
Oct 27, 2021
Comment on lines
+112
to
+113
| // FIXME: We are assuming a shard width <= 256 (the default) to easily | ||
| // convert to and from a byte slice. |
There was a problem hiding this comment.
Working on this (extending the hashBits structure to see if it naturally fits into the HAMT API).
|
closed by the alternative in #111 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Walk the HAMT in memory without needing to serialization (i.e., storing it).
Meant to fix sharness in ipfs/kubo#8114 and the correctness of the walk in general.