-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in dagutils MergeDiffs. #59
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
I think this is OK, but would you mind trying to add a simple test case for it? |
Yeah I'll update when I have some free time this week. |
@rvagg I cleaned up the diff function and added some tests for it as well. Hopefully this all looks good and can be merged soon. |
@Stebalien Can you take a look at this? |
@nasdf a lot of people are unavailable over the next little bit due to holidays (Dec - Jan is frequently rough for getting things merged in). Things should start picking back up later this month and then we can hopefully get this taken care of. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very nice code cleanup in general, and tests, and I think it's just the single delete
that might be doing all of the fix work here, so thanks for going the extra mile! lgtm.
This fixes a bug where conflicts were also returned as changes when merged.