Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

feat!: add and connect missing context, remove RemovePinWithMode #23

Merged
merged 2 commits into from
Feb 22, 2023
Merged

feat!: add and connect missing context, remove RemovePinWithMode #23

merged 2 commits into from
Feb 22, 2023

Commits on Jan 16, 2023

  1. add and connect missing go context

    @MichaelMure
    MichaelMure committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    3b0d257 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Make PinWithMode() return an error, share most of the code with Pin() 

    Now that PinWithMode() takes a context and return an error, there is not that
much difference with Pin(). Those differences are:
- Pin() store the root node and fetch the graph if recursive
- Pin() accept an ipld.Node, PinWithMode() accept a CID (kinda meaningless)
- Pin() accept a "recurse" boolean, PinWithMode() accept a Mode, but only Direct and Recursive values

There is a case to be made to merge those or eliminate one.
    @MichaelMure
    MichaelMure committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    369f7cb View commit details
    Browse the repository at this point in the history