Add Gateway.APICommands for /api allowlists #10
Conversation
ghost
self-assigned this
ghost
force-pushed
the
feat/gateway-commands
branch
from
2c818da to
e825524
Compare
init.go
Outdated
| @@ -66,6 +66,7 @@ func Init(out io.Writer, nBitsForKeypair int) (*Config, error) { | |||
| "Access-Control-Allow-Methods": []string{"GET"}, | |||
| "Access-Control-Allow-Headers": []string{"X-Requested-With", "Range"}, | |||
| }, | |||
| APICommands: DefaultGatewayAPICommands(), | |||
There was a problem hiding this comment.
Will it end up writing these to the config? If it does, I'm worried we won't be able to add commands later without a migration.
There was a problem hiding this comment.
I guess alternatively we could keep the default an empty array?
serialize/serialize.go
Outdated
| @@ -55,17 +54,26 @@ func encode(w io.Writer, value interface{}) error { | |||
| } | |||
|
|
|||
| // Load reads given file and returns the read config, or error. | |||
| func Load(filename string) (*config.Config, error) { | |||
| func Load(filename string, cfg interface{}) error { | |||
There was a problem hiding this comment.
Where's the cyclic import this is fixing?
There was a problem hiding this comment.
It makes use of code that lives/lived one directory up, so gx-go rw wasn't able to rewrite the import path here
There was a problem hiding this comment.
Ah, this PR branch is based off #9
There was a problem hiding this comment.
Hm. I can't reproduce. Let's discuss there.
ghost
mentioned this pull request
ghost
force-pushed
the
feat/gateway-commands
branch
from
e825524 to
4eccf67
Compare
ghost
force-pushed
the
feat/gateway-commands
branch
from
4eccf67 to
ef208a2
Compare
|
Updated -- removed the gx dep commit, and moving the actual default commands list to go-ipfs itself. |
|
LGTM, merge when ready. |
For ipfs/kubo#4595 (comment)
No fs-repo migration needed.