cli: fix ignoring std{out,err} sync errors on windows #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
djdv
suggested changes
Feb 25, 2019
cli/error_windows.go
Outdated
| const invalid_file_handle syscall.Errno = 0x6 | ||
|
|
||
| func isErrnoNotSupported(err syscall.Errno) bool { | ||
| switch e { |
| if !ok { | ||
| return false | ||
| } | ||
| return perr.Op == "sync" && isErrnoNotSupported(perr.Err) |
There was a problem hiding this comment.
Compiler is complaining about a lack of type assertion for perr
cannot convert perr.Err (type error) to type syscall.Errno: need type assertion
Apparently, windows returns "invalid file handle" and golang doesn't translate this to EINVAL. fixes ipfs/kubo#6021
Stebalien
force-pushed
the
fix/sync-stderr-windows
branch
from
6834247 to
9d994fb
Compare
|
(fixed) |
djdv
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes ipfs/kubo#6021