This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
ci: add check to ensure generated files are up-to-date #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noticed that this won't work for now because the edelweiss output is not deterministic (the import names change) |
|
This is due to https://github.com/ipld/edelweiss/blob/b072474ae32909c6e0c4e96a44ad5aefc037c068/codegen/blueprint.go#L49-L58, which is iterating over a map which has non-deterministic order |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests for this should fail, because the generated code is out-of-date. I'll follow up with a fix for that, but it's useful for it to fail here, to demonstrate that it works.